uzix/picocom
1
0
Fork 0
mirror of https://github.com/UzixLS/picocom.git synced 2025-07-19 07:21:18 +03:00
Code Issues Projects Releases Wiki Activity

Explicitly unlock tty_fd before exiting

Browse Source 
Call flock(fd, LOCK_UN) explicitly for managed file at term_exitfunc().

This should, normally, not be necessary. Normally, exiting the program
should take care of unlocking the file. Unfortuntelly, it has been
observed that, on some systems, exiting or closing an flock(2)'ed tty fd
has peculiar side effects (like not reseting the modem-control lines,
even if HUPCL is set).
This commit is contained in:
Nick Patavalis
2018-01-20 13:19:51 +02:00
parent 007072bd57
commit dabb708a8c
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
term.c
View File

@ -35,6 +35,9 @@
#include <errno.h> #include <errno.h>
#include <unistd.h> #include <unistd.h>
#include <termios.h> #include <termios.h>
#ifdef USE_FLOCK
#include <sys/file.h>
#endif
/* glibc for MIPS has its own bits/termios.h which does not define /* glibc for MIPS has its own bits/termios.h which does not define
* CMSPAR, so we use the value from the generic bits/termios.h * CMSPAR, so we use the value from the generic bits/termios.h
@ -407,6 +410,17 @@ term_exitfunc (void)
fprintf(stderr, "%s: reset failed for dev %s: %s\r\n", fprintf(stderr, "%s: reset failed for dev %s: %s\r\n",
__FUNCTION__, tname, strerror(errno)); __FUNCTION__, tname, strerror(errno));
} }
#ifdef USE_FLOCK
/* Explicitly unlock the file. If the file is not in fact
flock(2)'ed, no harm is done. This should normally not
be necessary. Normally, exiting the program should take
care of unlocking the file. Unfortuntelly, it has been
observed that, on some systems, exiting or closing an
flock(2)'ed tty fd has peculiar side effects (like not
reseting the modem-control lines, even if HUPCL is
set). */
flock(term.fd[i], LOCK_UN);
#endif
term.fd[i] = -1; term.fd[i] = -1;
} }
} while (0); } while (0);