From 849532b261ff7cc2531bf306292d5e58c93b0d4c Mon Sep 17 00:00:00 2001 From: Nick Patavalis Date: Sun, 21 Jan 2018 21:16:26 +0200 Subject: [PATCH] Replaced strcpy in init_history() Mostly to avoid compiler warnings on some systems --- picocom.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/picocom.c b/picocom.c index 7286403..36fba37 100644 --- a/picocom.c +++ b/picocom.c @@ -540,13 +540,14 @@ void init_history (void) { char *home_directory; + int home_directory_len; home_directory = getenv("HOME"); if (home_directory) { - history_file_path = malloc(strlen(home_directory) + 2 + - strlen(HISTFILE)); - strcpy(history_file_path, home_directory); - if (home_directory[strlen(home_directory)-1] != '/') { + home_directory_len = strlen(home_directory); + history_file_path = malloc(home_directory_len + 2 + strlen(HISTFILE)); + memcpy(history_file_path, home_directory, home_directory_len + 1); + if (home_directory[home_directory_len - 1] != '/') { strcat(history_file_path, "/"); } strcat(history_file_path, HISTFILE);